[VL] Surface full Velox exception context in native plan validation JNI#12161
Open
Yao-MR wants to merge 2 commits into
Open
[VL] Surface full Velox exception context in native plan validation JNI#12161Yao-MR wants to merge 2 commits into
Yao-MR wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
PlanEvaluatorJniWrapper::nativeValidateWithFailureReasononly catchesstd::invalid_argument. Any other native error - including aVeloxExceptionthrown from inside
SubstraitToVeloxPlanValidator::validate- falls throughto
JNI_METHOD_END, which converts it to a JavaGlutenExceptionusing onlye.what(). The JVM therefore receives the bare error message (e.g."duplicated rule") with no information about which component failed,no
errorSource/errorCode, no failing expression, no native stack trace.This PR adds an explicit
VeloxExceptioncatch in the JNI handler that logsthe full diagnostic context to
LOG(ERROR)and then re-throws so the existingJNI_METHOD_ENDpath is preserved verbatim:How was this patch tested?
mock exception and test the ut.
related ISSUE: #12141
Was this patch authored or co-authored using generative AI tooling?